Prepare for a new release#5
Conversation
7b7e49f to
0b64e98
Compare
| doc: "https://hackwaly.github.io/ocaml-dap/" | ||
| depends: [ | ||
| "ocaml" {>= "4.08"} | ||
| "ocaml" {>= "4.11"} |
There was a problem hiding this comment.
Just wondering, where is this new minimum coming from?
It's not a problem for earlybird though because it has an OCaml 4.12 lower bound for quite a while now.
There was a problem hiding this comment.
I chose it based on the lower bound in opam-repository. It would be better to match earlybird's 4.12 bounds, I'll do that.
There was a problem hiding this comment.
What lower bound in opam-repository? It's still 4.08 here: https://github.com/ocaml/opam-repository/blob/bc64c70f8353cd2940ce5f9a4c0b5b13d8043bf5/packages/dap/dap.1.0.6/opam#L14.
It doesn't have to match earlybird. Artificially bumping the lower bound when it would work fine on older version is unnecessary.
There was a problem hiding this comment.
There was a problem hiding this comment.
I see. I wouldn't set the package's lower bound based on that because I suppose it still builds fine for the earlier versions, unless something in this PR wouldn't.
The OCaml version lower bound for opam-repository is mostly for archiving packages which only build on the older versions. There are still packages that support both older and newer than 4.11 in opam-repository.
But I won't adamantly fight against the lower bound bump either. I guess it could be convenient for starting to use some newer language or Stdlib features.
There was a problem hiding this comment.
I've added the necessary CI config to get 4.08 working in 783ad15
53dedde to
aac5a2f
Compare
Backport package versions for result and fmt from opam-repository. Updates OCaml version to 4.11 to match the lower bound on opam-repository packages. More explicit with-test installation of ppx_expect and fmt packages.
Also conditionally run tests on supported OCaml versions
aac5a2f to
783ad15
Compare
2 participants
Each commit should be self explanatory @sim642
My intention is to make a new release 1.1 of this package that supports OCaml 4.11 onwards. We might need to constrain older versions of earlybird away from using this new version, I'll rely on the opam repo CI to discover that.