Lieux: edit a location (fix typos / dimensions / parent)#90
Merged
Conversation
Follow-up to the location-delete work: a location couldn't be corrected after creation (e.g. a name typo). Add edit, mirroring the crop edit form. - Each location row gets a Modifier button; it loads the location into the form (edit mode: title "Modifier le lieu", Save / Cancel). Save updates the existing location instead of creating a new one. - App: `update_location` (reuses `Location::new` validation, keeps the id) and `get_location_for_edit`. Reparenting under a descendant is rejected by the repo's cycle check and surfaced as a localized message (`error-location-cycle`). - New i18n keys (fr/en): edit section title, updated status, cycle error. Tests: `update_location_changes_name`, `update_location_rejects_parent_cycle`. Workspace green (337), clippy + fmt clean. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the location-delete work (#89). A location couldn't be corrected after creation — e.g. a name typo. This adds editing, mirroring the crop edit form (#88).
Changes
update_location(reusesLocation::newvalidation, keeps the original id) andget_location_for_edit. Reparenting under a descendant is rejected by the repository's existing cycle check and surfaced as a localized message (error-location-cycle).Verification
update_location_changes_name,update_location_rejects_parent_cycle.cargo test --workspace(337) green,cargo clippy --workspace --all-targets+cargo fmt --checkclean.🤖 Generated with Claude Code