Skip to content

feat: open specific guild vaults by number - #775

Merged
darbyjack merged 2 commits into
masterfrom
feat/direct-vault-access
Jul 12, 2026
Merged

feat: open specific guild vaults by number#775
darbyjack merged 2 commits into
masterfrom
feat/direct-vault-access

Conversation

@darbyjack

@darbyjack darbyjack commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary

Add direct access to numbered guild vaults while preserving the existing vault picker behavior.

Players can now use:

  • /guild vault to open the existing picker GUI
  • /guild vault <number> to open a specific unlocked vault directly

Changes

  • add an optional vault number argument to the existing vault command
  • extract vault opening into a shared VaultGUI.open path used by both the command and picker
  • validate one-based vault numbers against the guild tier
  • create every missing cached vault up to the requested number before opening it
  • use the loop index for picker numbering and click handling
  • remove the shared companion-object counter from VaultGUI

Why

The previous picker kept a static counter shared by every GUI instance and only created one missing vault per click. Opening a higher-numbered vault with an incomplete cache could still result in an out-of-bounds lookup.

Local validation

Ran standalone Kotlin behavior checks covering:

  • direct access to an unlocked vault
  • filling all missing vaults up to the requested number
  • opening the correct requested inventory
  • rejecting vault zero
  • rejecting vaults above the guild tier limit
  • avoiding cache mutation for invalid requests

Fixes #323

@darbyjack
darbyjack marked this pull request as ready for review July 12, 2026 03:00
@darbyjack
darbyjack merged commit ef83478 into master Jul 12, 2026
1 check passed
@darbyjack
darbyjack deleted the feat/direct-vault-access branch July 12, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request - Accessing Specific Vaults via Command

1 participant