fix: prevent duplicate visible guild names - #774
Merged
Conversation
darbyjack
marked this pull request as ready for review
July 12, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent guild creation and renaming from accepting a name that differs from an existing guild only by color formatting or letter case.
Root cause
Guild names are stored after translating alternate color codes, while the duplicate-name check compared the stored formatted string directly against the raw command input. This allowed visually identical names such as
&aKnightsand&bKnightsto coexist.Changes
GuildInputValidatorLocal validation
Compiled the exact validator locally with lightweight dependency stubs and ran standalone behavior checks covering:
&colors on the same visible name§-formatted names