fix: validate color-code markers against guild regex - #773
Merged
Conversation
darbyjack
marked this pull request as ready for review
July 12, 2026 02:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix guild name and prefix validation when
guild.requirements.include-color-codesis disabled.The setting continues to control whether valid color-code sequences count toward the configured length, but the raw color-code marker must still be permitted by the configured regex.
Root cause
The previous validation translated and stripped color codes before applying the regex. As a result, an input such as
&aGuildbecameGuildbefore validation, allowing&to bypass a regex that intentionally excluded it.Changes
GuildInputValidatorfor guild names and prefixes&) and section-sign (§) color-code markers are accepted by the configured regexLocal validation
Compiled the exact validator implementation locally with lightweight stubs and ran a standalone assertion harness covering:
&color codesFixes #266