fix(misc): harden guild damage, config parsing, and claims - #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes around plugin integration, configuration validation, and error handling. The main themes are safer and more robust integration with WorldGuard, improved validation and error reporting for configuration-driven features (such as guild buffs and ticket items), and general code quality improvements.
WorldGuard Integration Improvements:
WorldGuardListener,ClaimSignListener) are now only registered if WorldGuard is present and its wrapper can be initialized, preventing startup errors when WorldGuard is missing or misconfigured. (Guilds.java,ClaimSignListener.java,WorldGuardListener.kt) [1] [2] [3]WorldGuardWrapperinstance is now injected into listeners rather than being statically fetched, improving testability and reliability. (ClaimSignListener.java,WorldGuardListener.kt) [1] [2]Configuration Validation and Error Handling:
ClaimSignListener.java) [1] [2] [3]BuffGUI.kt)XMaterialfor cross-version compatibility, and falls back toPAPERwith a warning if the configured material is invalid. (GuildHandler.java) [1] [2]Code Quality and Maintenance:
addPotionmethod fromGuild.javaand unnecessary imports, cleaning up dead code. (Guild.java) [1] [2]EntityListener. (EntityListener.java) [1] [2]These changes collectively make the plugin more robust against misconfiguration, improve cross-version compatibility, and provide clearer error messages for both administrators and users.