refactor(update): isolate version comparison logic - #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the
UpdateCheckerclass, making the update-checking process more robust, modular, and easier to maintain. The changes include improved error handling, code modularization, and enhanced logging for update checks.Refactoring and modularization:
compareDecimalVersionsstatic method, and similarly, moved the logic for reading the newest version from the JSON response into a newreadNewestVersionmethod. This makes the code easier to read and maintain. [1] [2]Error handling and robustness:
requestUpdateCheck()by checking HTTP response codes before attempting to parse the response, handling more specific exceptions, and ensuring the HTTP connection is always closed in afinallyblock.runCheck()to provide clearer warning messages when update checks fail, including logging exceptions if present.Code quality improvements: