fix(database): load SQL libraries with Quark - #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the way database driver and data source class names are managed and detected in the
DatabaseManagerclass. The changes enhance flexibility and robustness in loading JDBC drivers, particularly for SQLite, and improve error messaging for missing drivers.Refactoring and improvements to class name detection:
requireDataSourceNametorequireDataSourceClassNameand introduced a new methodrequireDriverClassName, both of which utilize a shared helper methodrequireClassNamefor class detection and error reporting. This centralizes and clarifies the logic for checking required classes.isClassAvailablemethod to check multiple class loaders (including the current, context, and system class loaders), increasing the chances of successfully detecting JDBC driver classes across different runtime environments.Backend-specific configuration updates:
config.setDriverClassNameusing the newrequireDriverClassNamemethod, ensuring the correct JDBC driver is explicitly set for SQLite connections.requireDataSourceClassNamemethod for setting the data source class name, improving consistency. [1] [2]Error reporting and connection details:
requireClassNameto specify the type of class (driver or datasource) that is missing and to suggest ensuring the JDBC driver is available at runtime.