Remove legacy server side AB test framework#28888
Draft
DanielCliftonGuardian wants to merge 2 commits into
Draft
Remove legacy server side AB test framework#28888DanielCliftonGuardian wants to merge 2 commits into
DanielCliftonGuardian wants to merge 2 commits into
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Removes the old server-side AB testing framework which has been superseded.
The old framework had no active experiments so it was already a no-op.
What does this change?
Deleted core framework and related code.
I have moved ContentPresser feature switch to FeatureSwitches from the now deleted ServerSideExperimentSwitches
Warning
This PR drops the
abTestsfield from the DCR payload, which DCR currently lists asrequired.Do not deploy to PROD until the companion dotcom-rendering change (make
abTestsoptional,remove from schema
required[], stop reading it) is live in PROD.Deployment steps:
abTestsoptional + de-referencedabTestsproperty + schema definition