[AVI-248] Add Darwin System Config for VM Builders#148
Conversation
Nughm3
left a comment
Nughm3
left a comment
There was a problem hiding this comment.
This looks good but I don't run MacOS or Nix at the moment so I can't really say for sure
| system = { | ||
| disableInstallerTools = false; | ||
| extraDependencies = lib.mkForce [ ]; | ||
| switch.enable = false; |
There was a problem hiding this comment.
This does reduce image size a bit, but it completely eliminates the ability to update embedded machines without reflashing the entire OS. I don't think it's a good idea as a blanket rule, but may be applicable to individual machines. Either way, it has nothing to do with Darwin machines and shouldn't be in this PR.
| virtualisation = { | ||
| cores = 4; | ||
|
|
||
| darwin-builder = { |
There was a problem hiding this comment.
@acr12856 didn't you have an issue compiling this for the first time, since the builder parameters are changed? We need to make sure that first-time users can compile it with a single command.
| platform = enumerateTargets ./platform; | ||
| }; | ||
|
|
||
| nixpkgsFixes = final: prev: { |
There was a problem hiding this comment.
I'm not sure what led to the inclusion of this, but I would highly recommend against it since it seems like a bodge fix that doesn't address some underlying issue. You should never have to do this, and it gives major code smells that an AI agent found some problem and made a hacky fix without understanding the underlying problem.
3 participants
No description provided.