Homework #3 First Run#6
Open
gsiri-code wants to merge 3 commits into
Open
Conversation
e616114 to
50f7686
Compare
refactor: use ruff for simple lint fixes feat: add official oss-api tickets_api config: add dependencies tickets_api and tickets_client_impl feat: add demonstration file to tickets_client_impl fix: logging syntax fix: remove all export from tickets_impl fix: update logging of main main tickets client impl docs: update documentation of tickets_impl docs: add mkdocs config and mkdocs support for libraries and existing documentation fix: libraries md formating lint: resolve ruff and mypy
50f7686 to
6359dc5
Compare
Remedied mistake in main.py and test_gtask.py causing issues in testing. Two other tests were impacted temporarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
What problem is being solved?
Adapts
gtask_implto be called withtickets_api, usingtickets_client_implas an adapter ensuring seamless interaction betweengtask_implandtickets_api.Why now? Any user-visible impact?
We need to ensure that
gtask_implworks seamlessly withtickets_api. Therefore users can call methods or attributes defined inticekts_api's classes, and call upon the intended implementation of google tasks.Related Issues
Closes # (if applicable)
Relates to # (if applicable)
Change Type
Impacted Areas
mail_client_apigmail_client_impltickets_apiandtickets_client_implpackages, updated MkDocs configurationTesting
Commands executed
Results
Quality Checklist
Breaking Changes (skip if none)
N/A - This is a new feature addition with no breaking changes to existing code.
Notes for Reviewers
Key Implementation Details:
Status Mapping Strategy: The implementation uses a clever mapping where:
OPENtickets map to tasks with status"needsAction"and no prefixIN_PROGRESStickets map to tasks with status"needsAction"and title prefix"(IP) "CLOSEDtickets map to tasks with status"completed"(prefix removed if present)Update Behavior: Since Google Tasks doesn't support direct updates,
update_ticket()uses a delete-and-recreate pattern. This means the underlying task ID changes, but the ticket interface maintains the original ID for the caller.Tasklist Strategy: The implementation uses the first available tasklist from
list_tasklists()and caches it for all operations.Test Coverage: Comprehensive test suite includes:
Documentation: Added MkDocs configuration and library documentation pages for all components, including the new tickets libraries.
Follow-ups:
Nonesince Google Tasks doesn't support assignees