Websocket Support by aidenscott2016 · Pull Request #77 · grug/data-mocks

aidenscott2016 · 2021-09-14T16:11:10Z

We have had a need to mock a WS server at OVO using this library. This work implements that.

grug · 2021-09-14T20:32:43Z

This looks pretty solid. I'll give this a run when I'm at my desktop tomorrow. I really appreciate contributions like this out of the blue!

grug · 2021-09-15T13:30:06Z

Aiden I need to see a dank meme before I can approve this work.

aidenscott2016 · 2021-09-15T13:51:35Z

-    "noUnusedLocals": true /* Report errors on unused locals. */,
-    "noUnusedParameters": true /* Report errors on unused parameters. */,
+    "noUnusedLocals": false /* Report errors on unused locals. */,
+    "noUnusedParameters": false /* Report errors on unused parameters. */,


change comes from within, brother 😌

aidenscott2016 · 2021-09-15T13:51:42Z


+# modified by aiden for websocket support.
+# will hopefully be deleted soon when merged in to upstream
+


also write usage

Can you fix this up?

aidenscott2016 · 2021-09-15T14:45:35Z

@grug

This looks pretty solid. I'll give this a run when I'm at my desktop tomorrow. I really appreciate contributions like this out of the blue!

You're welcome. We needed to mock websockets any way and it didn't make sense two sets of mocking infra

Aiden I need to see a dank meme before I can approve this work.

It will take a long time to find a suitably dank meme for a PR of this calibre. Now I can see there is an appetite to upstream this I will more than likely clean this up on my next 10pc day next friday

aidenscott2016 · 2021-09-15T14:55:07Z

@HamishDixon morley has aske me to remind you that you are a flim-flam

grug · 2021-09-15T14:55:47Z

@aidenscott2016 please remind Morley that I am his dad.

aidenscott2016 · 2021-09-24T12:37:05Z

@grug this is ready for merge

grug · 2021-09-24T12:52:18Z


+# modified by aiden for websocket support.
+# will hopefully be deleted soon when merged in to upstream
+


Can you fix this up?

grug · 2021-09-24T12:54:55Z

I'm going to have to run this stuff locally and see how it all works as I feel like people can get pretty fancy with their websocket setups so I want to see how this stands up against some weird configurations.

Co-authored-by: Dave Cooper <[email protected]>

aidenscott2016 · 2021-09-24T13:15:01Z

thumbs up emoji

grug · 2021-10-29T08:32:10Z

@aidenscott2016 are you still okay with all of this? I'm thinking of merging and releasing today :)

aidenscott2016 · 2023-10-21T17:28:25Z

@grug ye man merge it

Aiden added 9 commits September 10, 2021 13:46

add datamocks

74901d3

a test

0d37547

wip

2d4ef76

wft

b71c019

implement mock server

e12081c

test reduction

743b55c

remove log

5a4d8d8

v4.2.0

cdcb25a

bump version

34b0356

aidenscott2016 commented Sep 14, 2021

View reviewed changes

Comment thread package.json Outdated

post review change

ce1f4e0

aidenscott2016 commented Sep 15, 2021

View reviewed changes

Comment thread src/mocks.test.ts Outdated

aidenscott2016 commented Sep 15, 2021

View reviewed changes

Comment thread src/mocks.ts Outdated

aidenscott2016 commented Sep 15, 2021

View reviewed changes

Comment thread src/mocks.ts

aidenscott2016 commented Sep 15, 2021

View reviewed changes

Comment thread src/mocks.ts

restore origin package json

ea3a10f

aidenscott2016 force-pushed the websocket branch from ad9a419 to 75aa057 Compare September 24, 2021 12:24

Aiden added 2 commits September 24, 2021 13:24

bits and pieces

49c0560

readme

8df38c7

aidenscott2016 force-pushed the websocket branch from 75aa057 to 8df38c7 Compare September 24, 2021 12:36

aidenscott2016 marked this pull request as ready for review September 24, 2021 12:36

aidenscott2016 changed the title ~~Draft PR to support websockets~~ Websocket Support Sep 24, 2021

grug reviewed Sep 24, 2021

View reviewed changes

Repository owner deleted a comment from aidenscott2016 Sep 24, 2021

aidenscott2016 and others added 2 commits September 24, 2021 14:14

Update README.md

0340b2d

Co-authored-by: Dave Cooper <[email protected]>

readme

c7f7f4b


		# modified by aiden for websocket support.
		# will hopefully be deleted soon when merged in to upstream

Conversation

aidenscott2016 commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

grug commented Sep 14, 2021

Uh oh!

grug commented Sep 15, 2021

Uh oh!

aidenscott2016 Sep 15, 2021

Choose a reason for hiding this comment

Uh oh!

kevrowe Sep 15, 2021

Choose a reason for hiding this comment

Uh oh!

HarrisonBaxter Sep 15, 2021

Choose a reason for hiding this comment

Uh oh!

aidenscott2016 Sep 15, 2021

Choose a reason for hiding this comment

Uh oh!

aidenscott2016 Sep 15, 2021

Choose a reason for hiding this comment

Uh oh!

grug Sep 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aidenscott2016 commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aidenscott2016 commented Sep 15, 2021

Uh oh!

grug commented Sep 15, 2021

Uh oh!

aidenscott2016 commented Sep 24, 2021

Uh oh!

grug Sep 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

grug commented Sep 24, 2021

Uh oh!

aidenscott2016 commented Sep 24, 2021

Uh oh!

grug commented Oct 29, 2021

Uh oh!

aidenscott2016 commented Oct 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aidenscott2016 commented Sep 14, 2021 •

edited

Loading

aidenscott2016 commented Sep 15, 2021 •

edited

Loading