Skip to content

feat(vsc-converter-station-measurements): add mapping for measurements in vsc converter station#343

Open
KoloMenek wants to merge 1 commit into
mainfrom
marutk/feat/add_vsc_converter_stations_measurements_modification
Open

feat(vsc-converter-station-measurements): add mapping for measurements in vsc converter station#343
KoloMenek wants to merge 1 commit into
mainfrom
marutk/feat/add_vsc_converter_stations_measurements_modification

Conversation

@KoloMenek

Copy link
Copy Markdown
Member

add mapping for measurements in vsc converter station

…s in vsc converter station

Signed-off-by: Kamil MARUT <[email protected]>
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dabb9c80-1666-47f4-a392-35c43aa45fcf

📥 Commits

Reviewing files that changed from the base of the PR and between 0ce765f and e1968d1.

📒 Files selected for processing (3)
  • src/main/java/org/gridsuite/network/map/dto/definition/vscconverterstation/VscConverterStationFormInfos.java
  • src/main/java/org/gridsuite/network/map/dto/mapper/VscConverterStationInfosMapper.java
  • src/test/resources/hvdc-lines-vsc-form-data.json

📝 Walkthrough

Walkthrough

The PR extends the VSC converter station form DTO by adding two optional measurement fields (measurementP and measurementQ) representing active and reactive power measurements. The changes include DTO field definitions with proper imports and JSON serialization annotations, mapper integration that chains these fields into the builder, and corresponding test data updates demonstrating the measurements in both converter stations.

Changes

VSC Converter Station Measurement Fields

Layer / File(s) Summary
Form DTO measurement fields
src/main/java/org/gridsuite/network/map/dto/definition/vscconverterstation/VscConverterStationFormInfos.java
Imports MeasurementsInfos and Optional, then defines measurementP and measurementQ as optional fields with @JsonInclude(JsonInclude.Include.NON_ABSENT) to control JSON serialization of absent values.
Mapper integration and test fixtures
src/main/java/org/gridsuite/network/map/dto/mapper/VscConverterStationInfosMapper.java, src/test/resources/hvdc-lines-vsc-form-data.json
Mapper builder chains measurementP(...) and measurementQ(...) calls; test data includes measurement objects with value and validity fields in HVDC3 and HVDC4 converter stations.

Suggested reviewers

  • benrejebmoh
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding measurement mapping functionality to VSC converter stations.
Description check ✅ Passed The description is directly related to the changeset, describing the addition of measurement mapping for VSC converter stations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant