Skip to content

add fictitious injection in bus tab view#342

Merged
anass45 merged 1 commit into
mainfrom
add-fictitious-injection
Jun 11, 2026
Merged

add fictitious injection in bus tab view#342
anass45 merged 1 commit into
mainfrom
add-fictitious-injection

Conversation

@anass45

@anass45 anass45 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Allows displaying fictitious injection (P0,Q0) in the Bus tab view

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@anass45, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3723ab36-241b-40a0-8ebe-4ef99db44ac4

📥 Commits

Reviewing files that changed from the base of the PR and between 1e612e7 and 0dd8966.

📒 Files selected for processing (7)
  • src/main/java/org/gridsuite/network/map/dto/definition/bus/BusTabInfos.java
  • src/main/java/org/gridsuite/network/map/dto/mapper/BusInfosMapper.java
  • src/main/java/org/gridsuite/network/map/services/NetworkMapService.java
  • src/test/resources/all-data-in-variant.json
  • src/test/resources/all-data-without-optionals.json
  • src/test/resources/all-data.json
  • src/test/resources/buses-tab-data.json
📝 Walkthrough

Walkthrough

Adds nullable fictitiousP0 and fictitiousQ0 to BusTabInfos, maps them conditionally in BusInfosMapper for NODE_BREAKER topology, switches BUS element lookup to BusView in NetworkMapService#getElementInfos, and updates JSON test fixtures to include the new fields.

Changes

Bus fictitious power support

Layer / File(s) Summary
Fictitious power DTO fields and mapper wiring
src/main/java/org/gridsuite/network/map/dto/definition/bus/BusTabInfos.java, src/main/java/org/gridsuite/network/map/dto/mapper/BusInfosMapper.java
Adds nullable fictitiousP0 and fictitiousQ0 Double fields to BusTabInfos (serialized only when non-null). BusInfosMapper.toTabInfos imports TopologyKind, reads the voltage level topologyKind, and sets those fields only when topologyKind is NODE_BREAKER.
Element lookup change
src/main/java/org/gridsuite/network/map/services/NetworkMapService.java
NetworkMapService#getElementInfos resolves ElementType.BUS identifiers via network.getBusView().getBus(...); other element types continue to use network.getIdentifiable(...).
Test fixtures updated with new fields
src/test/resources/buses-tab-data.json, src/test/resources/all-data-in-variant.json, src/test/resources/all-data-without-optionals.json, src/test/resources/all-data.json
Adds fictitiousP0 and fictitiousQ0 numeric fields (typically 0.0) to several bus and voltage-level records used by tests and fixtures.

Suggested reviewers

  • sBouzols
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly summarizes the main change: adding fictitious injection (P0, Q0) display in the Bus tab view, which matches the core changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining that it allows displaying fictitious injection (P0, Q0) in the Bus tab view.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@anass45 anass45 self-assigned this Jun 10, 2026
@anass45 anass45 force-pushed the add-fictitious-injection branch 2 times, most recently from f770717 to 296a39d Compare June 10, 2026 15:35

@dbraquart dbraquart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: ok
tests: ok

  • node breaker network : fictitious values are returned in BUS sheet
  • bus breaker network : nothing is displayed (empty cells)
  • cucumber Estim-4 is now complete

@anass45 anass45 force-pushed the add-fictitious-injection branch from 75215d8 to 1e612e7 Compare June 11, 2026 11:15
@anass45 anass45 force-pushed the add-fictitious-injection branch from 1e612e7 to 0dd8966 Compare June 11, 2026 11:16
@sonarqubecloud

Copy link
Copy Markdown

@anass45 anass45 merged commit 0ce765f into main Jun 11, 2026
5 checks passed
@anass45 anass45 deleted the add-fictitious-injection branch June 11, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants