Skip to content

voltage measurements modification for busbar-section network-modification#338

Merged
benrejebmoh merged 3 commits into
mainfrom
busbar-voltage-measurements
May 29, 2026
Merged

voltage measurements modification for busbar-section network-modification#338
benrejebmoh merged 3 commits into
mainfrom
busbar-voltage-measurements

Conversation

@benrejebmoh

Copy link
Copy Markdown
Contributor

PR Summary

voltage measurements modification for busbar-section network-modification

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16ceced0-e592-444b-af51-acaf2d8d0ae7

📥 Commits

Reviewing files that changed from the base of the PR and between e7418c4 and e420ad6.

📒 Files selected for processing (3)
  • src/main/java/org/gridsuite/network/map/dto/definition/busbarsection/BusBarSectionFormInfos.java
  • src/main/java/org/gridsuite/network/map/dto/mapper/BusBarSectionInfosMapper.java
  • src/test/resources/bus-bar-section-form-data.json

📝 Walkthrough

Walkthrough

This PR adds voltage measurement data to bus bar section form information. A new optional measurementV field is introduced to BusBarSectionFormInfos with JSON serialization configured to exclude absent values, populated by the mapper from the underlying BusbarSection using voltage measurement type, and validated through test data updates.

Changes

Voltage Measurement Integration

Layer / File(s) Summary
Voltage measurement field definition
src/main/java/org/gridsuite/network/map/dto/definition/busbarsection/BusBarSectionFormInfos.java
BusBarSectionFormInfos adds imports for Optional and MeasurementsInfos, then declares a measurementV field typed as Optional<MeasurementsInfos> with @JsonInclude(Include.NON_ABSENT) to control JSON serialization.
Mapper population of voltage measurement
src/main/java/org/gridsuite/network/map/dto/mapper/BusBarSectionInfosMapper.java
toFormInfos method now populates the measurementV field on the builder by extracting a voltage measurement from the BusbarSection using toMeasurement(busbarSection, Type.VOLTAGE, 0).
Test data for voltage measurement
src/test/resources/bus-bar-section-form-data.json
Test fixture NGEN4 entry is updated to include a measurementV object containing value: 385.0 and validity: true.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'voltage measurements modification for busbar-section network-modification' directly relates to the main changeset, which adds voltage measurement support to the BusBarSectionFormInfos class.
Description check ✅ Passed The description is related to the changeset as it mentions voltage measurements for busbar-section, which aligns with the actual changes made in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@benrejebmoh benrejebmoh merged commit cdb2ddd into main May 29, 2026
4 checks passed
@benrejebmoh benrejebmoh deleted the busbar-voltage-measurements branch May 29, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants