Skip to content

Fix request of fetching line infos of attaching line#325

Open
basseche wants to merge 3 commits into
mainfrom
Replace_busbarSectionFinderTraver_usage
Open

Fix request of fetching line infos of attaching line#325
basseche wants to merge 3 commits into
mainfrom
Replace_busbarSectionFinderTraver_usage

Conversation

@basseche

@basseche basseche commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

PR Summary

To fix the bug on fetching line infos we replace the usage of BusbarSectionFinderTraverser class of Map-server by the one from powysbl-core.

@basseche basseche changed the title Fix fetching Line infos of attaching line Fix request of fetching line infos of attaching line Feb 10, 2026
@basseche basseche self-assigned this Feb 10, 2026
@basseche basseche force-pushed the Replace_busbarSectionFinderTraver_usage branch from bcfeddd to e3a5d42 Compare February 10, 2026 16:55
@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Rate limit exceeded

@basseche has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 16 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b893653-4037-4a13-83ec-7ac34cec5944

📥 Commits

Reviewing files that changed from the base of the PR and between 5ca3fea and a95c486.

📒 Files selected for processing (1)
  • src/test/java/org/gridsuite/network/map/mapper/BusbarSectionFinderTraverserTest.java
📝 Walkthrough

Walkthrough

Added a comprehensive test class for BusbarSectionFinderTraverser that builds a synthetic IIDM network with substations, busbar sections, switches, and lines, then validates traversal behavior across four distinct scenarios: open switch, closed last switch, all closed switches, and internal transformer connections.

Changes

BusbarSectionFinderTraverser Test Suite

Layer / File(s) Summary
Network fixture and setup
src/test/java/org/gridsuite/network/map/mapper/BusbarSectionFinderTraverserTest.java
Test class builds in-memory IIDM Network with two voltage levels, busbar sections with position extensions, disconnector/breaker topologies for fork and bypass paths, two-winding transformer, and transmission lines; working variant set to initial.
Traversal behavior test cases
src/test/java/org/gridsuite/network/map/mapper/BusbarSectionFinderTraverserTest.java
testWithOpenSwitch validates open last switch and incomplete closure; testWithClosedLastSwitch closes specific disconnectors and confirms closed switch with partial closure; testWithAllClosedSwitch closes multiple switches and asserts complete closure; testWithInternalConnection tests transformer terminal traversal with depth 1 and complete closure.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title mentions 'fetching line infos of attaching line' but the changeset only adds a test class for BusbarSectionFinderTraverser validation, not the actual fix or replacement of the class usage. Clarify whether this PR includes the actual replacement of BusbarSectionFinderTraverser usage or only adds test coverage for the class from powysbl-core.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description states the PR replaces BusbarSectionFinderTraverser usage with the powysbl-core implementation, which aligns with the test class being added to validate the new traverser behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@basseche basseche force-pushed the Replace_busbarSectionFinderTraver_usage branch from 5ca3fea to 6836113 Compare May 18, 2026 13:10
@basseche basseche force-pushed the Replace_busbarSectionFinderTraver_usage branch from a95c486 to f79e68f Compare May 18, 2026 13:14
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant