checkstyleparent27

[jonenst]

• parent27
• Checkstyle parent27 mostly cosmetic changes (opus4.6 assisted)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a5e698f5-76b3-4db2-b125-386bc728c2ad

📥 Commits

Reviewing files that changed from the base of the PR and between adcf9d2 and d45c8d4.

📒 Files selected for processing (1)

• src/test/java/org/gridsuite/filter/server/FilterEntityControllerTest.java

💤 Files with no reviewable changes (1)

• src/test/java/org/gridsuite/filter/server/FilterEntityControllerTest.java

---

📝 Walkthrough

Walkthrough

Bumps the Maven parent POM to 28, reorganizes import blocks across multiple server/entity/repository files, adds an ExpertFilterRepository interface, updates proxy import/exception formatting, and refactors several test assertions to use unconditional null checks.

Changes

Import Standardization and ExpertFilterRepository Introduction

Layer / File(s)	Summary
Parent POM version update pom.xml	Maven parent version bumped from 26.1 to 28.
Service and entity import standardization src/main/java/org/gridsuite/filter/server/FilterService.java, src/main/java/org/gridsuite/filter/server/NotificationService.java, src/main/java/org/gridsuite/filter/server/entities/AbstractFilterEntity.java, src/main/java/org/gridsuite/filter/server/entities/identifierlistfilter/IdentifierListFilterEquipmentEntity.java, src/main/java/org/gridsuite/filter/server/migrations/MigrateEquipmentFiltersToExpertFilters.java, src/main/java/org/gridsuite/filter/server/repositories/proxies/identifierlistfilter/IdentifierListFilterRepositoryProxy.java, src/test/java/org/gridsuite/filter/server/SupervisionControllerTest.java	Reordered and regrouped import statements for consistency (no logic or behavioral changes).
ExpertFilterRepository interface and proxy imports src/main/java/org/gridsuite/filter/server/repositories/expertfilter/ExpertFilterRepository.java, src/main/java/org/gridsuite/filter/server/repositories/proxies/AbstractFilterRepositoryProxy.java, src/main/java/org/gridsuite/filter/server/repositories/proxies/expertfiler/ExpertFilterRepositoryProxy.java	Adds @Repository ExpertFilterRepository extending FilterRepository<ExpertFilterEntity>; updates FilterMetadata import path in proxy; reformats exception message string concatenation.
Test assertion and formatting updates src/test/java/org/gridsuite/filter/server/FilterEntityControllerTest.java	Replaces try/catch-based queue emptiness check with unconditional assertNull(output.receive(...)) before clearing; reformats identifier-list export/metadata assertion calls across multiple lines without changing expected values.

Suggested reviewers

• thangqp
• antoinebhs
• sBouzols

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'checkstyleparent27' is vague and does not clearly convey the actual changes made in the pull request.	Use a more descriptive title such as 'Update Maven parent POM to version 28 and apply Checkstyle formatting changes' to clearly summarize the main objectives.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is related to the changeset, mentioning parent version updates and Checkstyle cosmetic changes, which align with the actual modifications.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/test/java/org/gridsuite/filter/server/FilterEntityControllerTest.java`:
- Around line 188-189: The assertions that iterate destinations
(destinations.forEach(... assertNull(... output.receive(...)))) can throw and
prevent output.clear() from running; wrap the assertion loop in a try-finally so
output.clear() is executed in the finally block. Specifically, enclose the
destinations.forEach(... assertNull(... output.receive(...))) invocation in a
try and move output.clear() into the corresponding finally to guarantee cleanup
of queues even if assertNull fails; reference the destinations.forEach lambda,
assertNull, output.receive(TIMEOUT, destination) and output.clear() when
applying the change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 158ecdf3-a0f2-4589-94c6-df9ef9ba68fa

📥 Commits

Reviewing files that changed from the base of the PR and between a6d76f6 and adcf9d2.

📒 Files selected for processing (12)

• pom.xml
• src/main/java/org/gridsuite/filter/server/FilterService.java
• src/main/java/org/gridsuite/filter/server/NotificationService.java
• src/main/java/org/gridsuite/filter/server/entities/AbstractFilterEntity.java
• src/main/java/org/gridsuite/filter/server/entities/identifierlistfilter/IdentifierListFilterEquipmentEntity.java
• src/main/java/org/gridsuite/filter/server/migrations/MigrateEquipmentFiltersToExpertFilters.java
• src/main/java/org/gridsuite/filter/server/repositories/expertfilter/ExpertFilterRepository.java
• src/main/java/org/gridsuite/filter/server/repositories/proxies/AbstractFilterRepositoryProxy.java
• src/main/java/org/gridsuite/filter/server/repositories/proxies/expertfiler/ExpertFilterRepositoryProxy.java
• src/main/java/org/gridsuite/filter/server/repositories/proxies/identifierlistfilter/IdentifierListFilterRepositoryProxy.java
• src/test/java/org/gridsuite/filter/server/FilterEntityControllerTest.java
• src/test/java/org/gridsuite/filter/server/SupervisionControllerTest.java

💤 Files with no reviewable changes (2)

• src/main/java/org/gridsuite/filter/server/repositories/expertfilter/ExpertFilterRepository.java
• src/test/java/org/gridsuite/filter/server/SupervisionControllerTest.java

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE