Skip to content

Bos coster msm - #311

Open
mykolas-alt wants to merge 1 commit into
grandinetech:mainfrom
mykolas-alt:bos-coster-msm
Open

Bos coster msm#311
mykolas-alt wants to merge 1 commit into
grandinetech:mainfrom
mykolas-alt:bos-coster-msm

Conversation

@mykolas-alt

Copy link
Copy Markdown

No description provided.

@ArtiomTr ArtiomTr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase from main branch, and when you finish, squash all your commits into one

Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread Cargo.toml
Comment thread fuzz/fuzz_targets/blst_fixed_msm.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread msm-benches/tests/failing_fuzzer.rs Outdated
@mykolas-alt

Copy link
Copy Markdown
Author

rebased, aligned api with the way arkmsm does it

@mykolas-alt
mykolas-alt force-pushed the bos-coster-msm branch 2 times, most recently from 4ef9c02 to fc4a2db Compare December 14, 2025 21:09
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/bos_coster.rs Outdated
Comment thread kzg/src/msm/msm_impls.rs Outdated
Comment thread msm-benches/Cargo.toml
Comment thread fuzz/Cargo.toml
@mykolas-alt
mykolas-alt force-pushed the bos-coster-msm branch 2 times, most recently from d013787 to b7d180b Compare December 17, 2025 06:51
@mykolas-alt
mykolas-alt marked this pull request as ready for review December 17, 2025 06:54

@ArtiomTr ArtiomTr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but still few changes needed. Also, don't forget to fix CI - kzg crate needs formatting to be fixed, and zkcrypto crate now has some issues with clippy. Those clippy issues would probably resolve after you remove feature checks between bos_coster and bgmw/arkmsm/wbits ones.

Comment thread fuzz/Cargo.toml
Comment thread kzg/src/msm/precompute.rs Outdated
Comment thread kzg/src/lib.rs
@mykolas-alt
mykolas-alt force-pushed the bos-coster-msm branch 3 times, most recently from c0585a4 to 221377a Compare January 21, 2026 06:50

@ArtiomTr ArtiomTr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Comment thread kzg/src/msm/precompute.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants