Wait for proposer preferences broadcasting to finish - #804
Open
hangleang wants to merge 1 commit into
Open
Conversation
povi
reviewed
Jul 13, 2026
|
|
||
| /// Broadcasts proposer preferences for the next epoch's slots where we are proposing. | ||
| #[instrument(level = "debug", skip_all)] | ||
| async fn broadcast_proposer_preferences(&self, slot_head: &SlotHead<P>) { |
Collaborator
There was a problem hiding this comment.
Have you tried to add wait_group: W param to broadcast_proposer_preferences and then drop(wait_group) on the last line inside tokio::spawn? This way it ensures that task is finished before checking test results (wait_for_tasks method call waits until all references to wait_group are dropped before continuing).
Member
Author
There was a problem hiding this comment.
CI build failed again, it still produced non-deterministic behavior
Collaborator
There was a problem hiding this comment.
Okay. Then previous approach may be better
hangleang
force-pushed
the
fix/broadcast-proposer-preferences-inline
branch
from
July 13, 2026 11:00
66cf725 to
f49c32b
Compare
hangleang
changed the title
hangleang
force-pushed
the
fix/broadcast-proposer-preferences-inline
branch
from
July 16, 2026 09:26
f49c32b to
079988f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
minimal_rapid_upgrade .. all_keys .. built_in_validatorsnapshot test failed on macOS CI:The run produced only
UpdateDataColumnSubnets+PublishBeaconBlockanddropped all 15
PublishProposerPreferencesmessages the snapshot expects.