ci: run the full test suite on pull requests#628
Merged
Conversation
… symlinks react-detect reports file paths with symlinks resolved, so on macOS (where /var/folders is a symlink to /private/var/folders) the archive dir prefix never matched and absolute temp paths leaked into results, failing the plugincheck2 integration test locally. Try the symlink-resolved archive dir as well.
The PR workflow only ran the MCP server tests and a docker build; the rest of the suite (60+ test files covering every analysis pass, the runner, and the plugincheck2 integration tests) stopped running in CI when the old build workflow was retired. Restore it: build plugincheck2 for the integration tests, install semgrep and node so the coderules and reactcompat paths are exercised, and run go test ./pkg/.... This is the gate we need before auto-merging dependency updates.
The parallel integration tests each invoke npx react-detect; on a cold runner the concurrent extractions corrupt npm's _npx cache and react-detect exits 127.
…tHub The test downloaded a real release zip from GitHub on every run and failed whenever that returned a 5xx (a 504 broke CI today). Build a minimal zip in memory and serve it from a local httptest server; the HTTP fetch path in ReadArchive stays covered.
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🧑💻 In development
in Grafana Catalog Team
andresmgot
approved these changes
Jul 10, 2026
github-project-automation
Bot
moved this from 🧑💻 In development
to 🔬 In review
in Grafana Catalog Team
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR workflow only ran the MCP server tests and a docker build. The rest of the suite (60+ test files covering every analysis pass, the runner, and the plugincheck2 golden-file integration tests) stopped running in CI when the old build workflow was retired, so a dependency bump could break any analyzer without CI noticing.
This restores the full run: build plugincheck2 for the integration tests, install semgrep and node so the coderules and reactcompat paths are exercised, and run
go test ./pkg/...on every PR. Tools the runner doesn't have (gosec, clamav) keep their existing skip behavior.Also fixes a macOS-only failure in the reactcompat pass: react-detect reports paths with symlinks resolved, so on macOS the temp dir prefix never matched and absolute paths leaked into the report, failing the integration test locally.
With this in place, green CI actually means the whole validator still works, which is the gate we need before auto-merging Renovate PRs.