[Merge after 6th July]Revert "Add backwards compatibility for old none of the above value"#2168
Draft
stephencdaly wants to merge 1 commit into
Draft
[Merge after 6th July]Revert "Add backwards compatibility for old none of the above value"#2168stephencdaly wants to merge 1 commit into
stephencdaly wants to merge 1 commit into
Conversation
This reverts commit 8550e8d.
stephencdaly
force-pushed
the
revert-fallback-for-none-of-the-above
branch
from
a3f4d9a to
5bc8249
Compare
lfdebrux
approved these changes
Jun 22, 2026
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2168.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 8550e8d.
We replaced storing the localised translation of "None of the above" with using a constant "none_of_the_above` regardless of the current language. All submissions including batch deliveries that contained the old value in the answers will have now been delivered so we can remove the fallback to support the old values.
Merge this after 6th July, as some submission soft-bounced on 2nd June and may have contained "None of the above" in their answers. Once these can no longer be re-sent we should be safe to merge.