xgo v1.7.1#88
Conversation
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| @@ -3,7 +3,7 @@ | |||
| [](https://github.com/goplus/tutorial/actions/workflows/gop.yml) | |||
There was a problem hiding this comment.
The Build Status badge URL and its link still reference the old gop.yml workflow path, which no longer exists after the rename to xgo.yml. Both the badge image src and the anchor href will be broken.
| [](https://github.com/goplus/tutorial/actions/workflows/gop.yml) | |
| [](https://github.com/goplus/tutorial/actions/workflows/xgo.yml) |
| gop-version: "main" | ||
| go-version: "1.24" | ||
| xgo-version: "main" | ||
|
|
There was a problem hiding this comment.
xgo-version: "main" pins to the live HEAD of the upstream main branch. This means every CI run pulls whatever commit exists at that moment — a compromised or breaking upstream push will silently affect all runs here with no change to this repo. It also prevents the setup action from caching the toolchain binary.
Consider pinning to the specific release tag that matches go.mod, e.g.:
| xgo-version: "v1.7.1" |
| @@ -1,5 +1,5 @@ | |||
| # This workflow will build a goplus project | |||
There was a problem hiding this comment.
This comment still says goplus project — worth updating to XGo project for consistency with the migration.
| # This workflow will build a goplus project | |
| # This workflow will build an XGo project |
| @@ -14,16 +14,16 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
There was a problem hiding this comment.
actions/checkout@v3 uses the Node 16 runtime which is end-of-life. Since the workflow is receiving maintenance in this PR, @v4 (Node 20) is worth picking up at the same time.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project's Go version to 1.24.0 and migrates the dependency from github.com/goplus/gop to github.com/goplus/xgo v1.7.1, including corresponding updates to the README and import paths. I have reviewed the changes and identified a critical issue: the go.mod and go.sum files are currently out of sync, likely due to missing go mod tidy execution. This will cause build failures in clean environments, and you must regenerate these files to include all necessary indirect dependencies and checksums.
| go 1.24.0 | ||
|
|
||
| require ( | ||
| github.com/goplus/gop v1.2.5 | ||
| github.com/goplus/xgo v1.7.1 |
There was a problem hiding this comment.
The go.mod and go.sum files appear to be out of sync. After updating the Go version and the xgo dependency, it is necessary to run go mod tidy. The current go.sum is missing many indirect dependencies (e.g., golang.org/x/mod which is required by github.com/goplus/mod), and go.mod is missing the // indirect block that Go 1.17+ automatically maintains. This will likely cause build failures in clean environments where these checksums are missing.
1 participant
No description provided.