fix(examples): wait for emulator port to open before executing samples#828
Open
olavloite wants to merge 3 commits into
Open
fix(examples): wait for emulator port to open before executing samples#828olavloite wants to merge 3 commits into
olavloite wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the emulator startup logic in examples/emulator_runner.go by waiting for port 9010 to be open and accepting connections, rather than just checking if the container is running. Feedback suggests using 127.0.0.1 instead of localhost to avoid dual-stack DNS resolution issues, and replacing <-time.After with time.Sleep to prevent unnecessary timer allocations within the loop.
olavloite
force-pushed
the
fix/samples-emulator-flakiness
branch
from
a9b4b26 to
c531981
Compare
Collaborator
Author
|
LGTM. Checking TCP port 9010 before returning from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves race conditions/flakiness in the samples test suite. Previously, startEmulator only checked if the container is running before returning. However, the Spanner emulator process takes some time to initialize and bind to port 9010. If a sample executes immediately, it fails with a 'connection reset by peer' error. Added a TCP Dial check loop to ensure port 9010 is open before returning from startEmulator.