fix(test): resolve flakiness in TestStatementTimeout#827
Open
olavloite wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TestStatementTimeout function in stmt_with_mockserver_test.go to configure a simulated execution time for ExecuteSql in addition to ExecuteStreamingSql. This change aligns with the updated comment clarifying that the database/sql driver uses ExecuteStreamingSql for queries and ExecuteSql for DMLs. There are no review comments, so no additional feedback is provided.
Collaborator
Author
|
LGTM. Setting a simulated execution time for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the flakiness in TestStatementTimeout by setting simulated execution time for MethodExecuteSql. DML statements use ExecuteSql under the hood, so without simulated delay they could execute in less than 1ms (returning OK instead of DeadlineExceeded).
Fixes #698