feat(impl_jni): add JCA AES-CBC implementation#304
Draft
mfazrinizar wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the JNI/JCA AES-CBC implementation on top of the existing Android JCA backend skeleton.
This PR implements:
Cipher("AES/CBC/PKCS5Padding")wiring withIvParameterSpecPKCS5Paddingis the JCA transformation name used for AES-CBC PKCS#7-style block padding.This PR depends on the separate
IvParameterSpecgenerated-binding PR #301. After that lands, this PR could then be tested againsttest/webcrypto_test.dart. This PR will be rebased after PR #298 and #300 approved and merged, therefore this is still a draft PR.Testing
dart analyzedart test test/impl_jni_aescbc_test.dartdart test test/webcrypto_test.dart -p vm -n AES-CBCflutter test integration_test/jni_aescbc_test.dart -d emulator-name