reject size class lists longer than kNumBaseClasses in sizemap#298
Open
dxbjavid wants to merge 1 commit into
Open
reject size class lists longer than kNumBaseClasses in sizemap#298dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetSizeClasses copies one entry per input size class into the class_to_size_, class_to_pages_ and num_objects_to_move_ arrays, which only hold kNumBaseClasses classes, but ValidSizeClasses validates just the first kNumBaseClasses entries and ignores anything beyond that. A size-class list longer than kNumBaseClasses therefore passes validation on its prefix and is then copied past the end of those fixed-size arrays, which is reachable through SizeMap::Init since the sizemap fuzzer drives it with arbitrary lists. This rejects over-long lists in the validator so Init returns false, the same way other malformed configurations are already handled.