Conversation
taku910
force-pushed
the
trainer
branch
8 times, most recently
from
July 18, 2026 04:38
fd00d50 to
d9c1521
Compare
- Defined pretokenizer as std::function<std::vector<std::string>(absl::string_view)> and enabled setting custom callbacks via Python API. - Unified pretokenization boundary enforcement (delimiter and callback) via 0x001F in LoadSentences. - Refactored sentence normalization in LoadSentences to use RunBatch for dynamic load-balancing. - Applied Pimpl pattern to TrainerComponents to eliminate sentencepiece_model.pb.h include from sentencepiece_trainer.h. - Enforced mutual exclusivity between pretokenizer callback and pretokenization_delimiter in VerifySpec. - Removed obsolete pretokenizer_for_training files and updated documentation. TAG=agy CONV=d3ccf372-3c94-4e30-81f2-fedd43ab6bcb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Trainer and pretokenization interface