Robust parameter identification for Qwix. - #281
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_917671214
branch
4 times, most recently
from
May 25, 2026 06:47
16628ad to
4ca162b
Compare
This CL enhances the parameter identification logic in find_param to better handle WithAux objects and auxiliary types in NNX and Linen modules. Key changes: - Refined find_param to handle WithAux input and correctly map its inner array to parameter names. - Conditionally extract .value for nnx.Param nodes to ensure robust parameter discovery. - Improved JAX tracer graph walking to handle auxiliary wrappers across scan boundaries. - Added support for jax.sharding.PartitionSpec in update_sharding and update_boxed. - Added unit tests in flax_util_test.py to verify these enhancements. PiperOrigin-RevId: 920802267
copybara-service
Bot
force-pushed
the
test_917671214
branch
from
May 25, 2026 06:56
4ca162b to
6a33d87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robust parameter identification for Qwix.
This CL enhances the parameter identification logic in find_param to better handle WithAux objects and auxiliary types in NNX and Linen modules.
Key changes: