Set up GitHub Actions workflows for tests, type-checking, and CLA - #279
Merged
Conversation
… skip google3 test - Python matrix 3.10 → 3.11 because flax>=0.12.0 (a qwix dep) drops 3.10 even though pyproject.toml classifiers still list it. - pyrefly check qwix/ — the pyrefly migration only covered qwix/_src and qwix/contrib; tests/ and integration_tests/ still have ~2600 type errors that block CI without adding value. - pytest --ignore tests/contrib/kernels/quantized_matmul_test.py — that file imports google3.testing.pybase which only exists in Google's internal monorepo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds three workflows under
.github/workflows/so that opening or updating a PR (and pushing tomain) runs the unit test suite, type-checks the codebase with pyrefly, and verifies that the contributor agreement checkboxes in the PR body are checked.What's included
test.yml— Unit tests. Runspython -m pytest tests/ -von Python 3.10 and 3.13 (min and max of the range declared inpyproject.toml). Installs withpip install -e ".[dev]". Uses pip caching keyed onpyproject.toml,fail-fast: falseso both matrix legs report independently, and aconcurrencygroup that cancels in-progress PR runs but letsmainruns finish.typecheck.yml— pyrefly. Single job on Python 3.13. Installs pyrefly from PyPI (it isn't in[dev]extras yet) and runspyrefly check, which picks up the existing[tool.pyrefly]config inpyproject.toml.cla.yml— Contributor Agreement check. Reads the PR body viaactions/github-scriptand fails the run if any of the three required checkboxes (I am a human...,I will be responsible...,I will work with the maintainers...) is unchecked. Guarded byif: github.repository == 'google/qwix'so it doesn't run on forks.PULL_REQUEST_TEMPLATE.mdupdate. Appends a## Contributor Agreementsection with the three checkboxes the CLA workflow looks for — without this, every PR would fail the CLA check.Design notes
integration_tests/) are intentionally out of scope for per-PR CI. They can be added on a nightly schedule if needed to run on GPU/TPU hardware.jax/jaxlibPyPI wheels.Declaration