Fix error when capture_source is enabled and test_start is None#1292
Open
harrish243 wants to merge 1 commit into
Open
Fix error when capture_source is enabled and test_start is None#1292harrish243 wants to merge 1 commit into
harrish243 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an AttributeError that occurs when the capture_source configuration is enabled but no test_start trigger is provided.
Why is this change needed?
In openhtf/core/test_descriptor.py, if test_start is passed as None, the trigger variable also evaluates to None. When CONF.capture_source is enabled, the code previously attempted to unconditionally access trigger.func, resulting in an error because it tried to get the func attribute on a None value.
How does this PR fix the problem?
I added a simple safety check (if CONF.capture_source and trigger:) so that it only attempts to capture the source code info if a valid trigger function actually exists.
Fixes #1279