Add support for custom units in OpenHTF proto converters.#1287
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_919012532
branch
8 times, most recently
from
14a01d8 to
6505559
Compare
copybara-service
Bot
force-pushed
the
test_919012532
branch
4 times, most recently
from
2bc664e to
790f7b9
Compare
This change modifies the mfg_event_converter and test_runs_converter to populate the custom_unit_code and custom_unit_suffix fields in the output protos when a measurement's unit code is not in the predefined UOM_CODE_MAP. New test cases are added to verify the correct handling of custom units in both converters. PiperOrigin-RevId: 930179956
copybara-service
Bot
force-pushed
the
test_919012532
branch
from
790f7b9 to
e08cff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for custom units in OpenHTF proto converters.
This change modifies the mfg_event_converter and test_runs_converter to populate the custom_unit_code and custom_unit_suffix fields in the output protos when a measurement's unit code is not in the predefined UOM_CODE_MAP. New test cases are added to verify the correct handling of custom units in both converters.