Skip to content

Add support for libsmpte2094-50#399

Merged
DichenZhang1 merged 2 commits into
google:mainfrom
vrabaud:smpte
Jul 7, 2026
Merged

Add support for libsmpte2094-50#399
DichenZhang1 merged 2 commits into
google:mainfrom
vrabaud:smpte

Conversation

@vrabaud

@vrabaud vrabaud commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread .github/workflows/cmake_linux.yml Outdated
Comment thread lib/src/gainmapmath.cpp Outdated
@vrabaud vrabaud force-pushed the smpte branch 4 times, most recently from f342743 to f1c1617 Compare June 17, 2026 22:17
@vrabaud

vrabaud commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Actually, this PR loses a bit of information because of the component mix that it does not use properly. Would there be a better place for me to put code ? The input would be the original image + AGTM metadata, the output would be a full gainmap.

@DichenZhang1

Copy link
Copy Markdown
Collaborator

The input would be the original image + AGTM metadata, the output would be a full gainmap.
Do you want to support it reversely, e.g. primary image + gain map (the Ultra HDR image input) -> primary image + AGTM in ICC?

I think it's better to split the logic into a standalone file agtm.h/.cpp, and this may also require API change

- Move SMPTE 2094-50 specific logic from GainLUT to new AgtmGainLUT in agtm.h/cpp.
- Add new generateGainMap API that takes image and SMPTE 2094-50 metadata.
- Move SMPTE related unit tests to agtm_test.cpp and add test for new API.
@DichenZhang1 DichenZhang1 merged commit 6f73d2d into google:main Jul 7, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants