Fix draw area issue#3804
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3804 +/- ##
============================================
+ Coverage 67.27% 67.50% +0.22%
- Complexity 1790 1798 +8
============================================
Files 405 405
Lines 10617 10625 +8
Branches 1353 1356 +3
============================================
+ Hits 7143 7172 +29
+ Misses 2781 2755 -26
- Partials 693 698 +5
🚀 New features to boost your workflow:
|
shobhitagarwal1612
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3400
Currently, when rotating the draw area task screen after the polygon was finished, the drawn polygon would be lost. This could also lead to a crash
java.lang.IllegalStateException - Attempted to add last vertex after completing the drawingif the 'Add point' would show again during this issue and the user clicked it.This was because the state was split between
draftAreawhich held only the first vertex anddraftUpdates, a no-replay SharedFlow. SincedraftUpdatesdoesn't replay, the current feature was lost so the shape vanished and buttons revertedNow draftArea carries the full geometry and buttons derive from sessionState, so both survive rotation.
FeatureManager.setFeatureswas updated so that a non-clustered feature whose tag already exists is updated instead of removed and re-added, which avoids potential flickering.Before:
Screen_recording_20260630_162746.webm
After:
Screen_recording_20260630_160754.webm
@shobhitagarwal1612 PTAL?