Skip to content

Fixed mypy errors on CI #5460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vfdev-5 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fixed mypy errors on CI #5460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flax/traceback_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
# Whether to filter flax frames from traceback.
_flax_filter_tracebacks = config.flax_filter_frames
# Flax specific set of paths to exclude from tracebacks.
_flax_exclusions = set()
_flax_exclusions = set() # type: ignore[var-annotated]
Copy link
Copy Markdown
Collaborator Author

@vfdev-5 vfdev-5 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignores:

flax/traceback_util.py:28: error: Need type annotation for "_flax_exclusions" (hint: "_flax_exclusions: set[<type>] = ...")  [var-annotated]



# re-import JAX symbol for convenience.
Expand Down
2 changes: 1 addition & 1 deletion flax/training/checkpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ def read_chunk(i):
else:
checkpoint_contents = fp.read()

state_dict = serialization.msgpack_restore(checkpoint_contents)
state_dict = serialization.msgpack_restore(bytes(checkpoint_contents))
Copy link
Copy Markdown
Collaborator Author

@vfdev-5 vfdev-5 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue:

flax/training/checkpoints.py:1166: error: Argument 1 to "msgpack_restore" has incompatible type "bytearray"; expected "bytes"  [arg-type]

state_dict = _restore_mpas(
state_dict,
target,
Expand Down
Loading