Convert rust_proto_library to a Starlark symbolic macro.#1424
Open
copybara-service[bot] wants to merge 1 commit into
Open
Convert rust_proto_library to a Starlark symbolic macro.#1424copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Convert `rust_proto_library` frontend macro to a Starlark symbolic macro (`macro(...)`). This allows restricting `use_upb_kernel` visibility to `//third_party/protobuf:__subpackages__`, avoiding the need to expose it publicly. Because Starlark symbolic macros strictly require that subtargets generated within macro `foo_rust_proto` start with `foo_rust_proto_`, subtarget naming is updated to `name + "_upb"` (`foo_rust_proto_upb`) and `name + "_cpp"` (`foo_rust_proto_cpp`). Also update `_user_visible_label` and rule validation in `rules.bzl` to handle the updated subtarget naming scheme. PiperOrigin-RevId: 947225402
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert rust_proto_library to a Starlark symbolic macro.
Convert
rust_proto_libraryfrontend macro to a Starlark symbolic macro (macro(...)). This allows restrictinguse_upb_kernelvisibility to//third_party/protobuf:__subpackages__, avoiding the need to expose it publicly.Because Starlark symbolic macros strictly require that subtargets generated within macro
foo_rust_protostart withfoo_rust_proto_, subtarget naming is updated toname + "_upb"(foo_rust_proto_upb) andname + "_cpp"(foo_rust_proto_cpp).Also update
_user_visible_labeland rule validation inrules.bzlto handle the updated subtarget naming scheme.