Introduce crubit::Value for C++ move semantics.#1419
Open
copybara-service[bot] wants to merge 1 commit into
Open
Introduce crubit::Value for C++ move semantics.#1419copybara-service[bot] wants to merge 1 commit into
crubit::Value for C++ move semantics.#1419copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_947125630
branch
3 times, most recently
from
450f854 to
ac0ab7f
Compare
`crubit::Value<T>` is a wrapper that enables C++ move semantics for types that are Rust-movable (i.e. support relocation) but not C++-movable. It introduces a "moved-from" state using a boolean flag, and uses `UnsafeRelocateTag` constructors when available to perform the move. This is useful for passing non-C++-movable Rust types by value in C++ by wrapping them in `Value<T>`. PiperOrigin-RevId: 947125630
copybara-service
Bot
force-pushed
the
test_947125630
branch
from
ac0ab7f to
a049f9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
crubit::Valuefor C++ move semantics.crubit::Value<T>is a wrapper that enables C++ move semantics fortypes that are Rust-movable (i.e. support relocation) but not C++-movable.
It introduces a "moved-from" state using a boolean flag, and uses
UnsafeRelocateTagconstructors when available to perform the move.This is useful for passing non-C++-movable Rust types by value in C++
by wrapping them in
Value<T>.