Take #2 on normalizing rs_std/cc_std.#1410
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
If we move the logic to another library, which is deployed with the release, then both `cc_std` and `rs_std` can live at head. Any version-specific stuff can be done by depending on that other library. (I don't really know why I didn't think of this earlier.) In Rust's case, this has to be a bazel library, with build-time feature flags. (This would avoid the surprising cc_std/cc_std_impl split.) In C++'s case, it's a header with some defines you can `#ifdef` on. (Could also reuse existing headers in bindings_support, but this might be less discoverable in the moment.) Could also use `defines`, but it's a bit of a heavy hammer, as it affects all transitive rdeps whether they include this transitively or only depend on it without including it (due to e.g. hourglass deps). This doesn't actually do anything, would need to wait for a crosstool release before we can migrate cc_std and rs_std. But I think after this, we could have everything except support/internal live at head, unless I am missing something. PiperOrigin-RevId: 946771812
copybara-service
Bot
force-pushed
the
test_946771812
branch
from
da03e72 to
6494b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take #2 on normalizing rs_std/cc_std.
If we move the logic to another library, which is deployed with the release, then both
cc_stdandrs_stdcan live at head. Any version-specific stuff can be done by depending on that other library. (I don't really know why I didn't think of this earlier.)In Rust's case, this has to be a bazel library, with build-time feature flags. (This would avoid the surprising cc_std/cc_std_impl split.)
In C++'s case, it's a header with some defines you can
#ifdefon. (Could also reuse existing headers in bindings_support, but this might be less discoverable in the moment.) Could also usedefines, but it's a bit of a heavy hammer, as it affects all transitive rdeps whether they include this transitively or only depend on it without including it (due to e.g. hourglass deps).This doesn't actually do anything, would need to wait for a crosstool release before we can migrate cc_std and rs_std. But I think after this, we could have everything except support/internal live at head, unless I am missing something.