Introduce a lifetime parameter to the IR struct on the Rust IR.#1402
Open
copybara-service[bot] wants to merge 1 commit into
Open
Introduce a lifetime parameter to the IR struct on the Rust IR.#1402copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
This is the first CL in a chain to deprecate duplicate IR structures onto the Rust heap for bindings generation. We parameterize IR<'a> with a lifetime so that it can eventually wrap a borrowed IRProtoView<'a> directly. This enables the generator to read directly from FFI-passed protos. PiperOrigin-RevId: 945831661
copybara-service
Bot
force-pushed
the
test_945831661
branch
from
3851b0b to
3c26bb3
Compare
copybara-service
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a lifetime parameter to the IR struct on the Rust IR.
This is the first CL in a chain to deprecate duplicate IR structures onto the Rust heap for bindings generation. We parameterize IR<'a> with a lifetime so that it can eventually wrap a borrowed IRProtoView<'a> directly. This enables the generator to read directly from FFI-passed protos.