Generate impl Debug bindings for records that impl_debug#1347
Open
copybara-service[bot] wants to merge 1 commit into
Open
Generate impl Debug bindings for records that impl_debug#1347copybara-service[bot] wants to merge 1 commit into
impl Debug bindings for records that impl_debug#1347copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_938342932
branch
6 times, most recently
from
827f162 to
ba3c91e
Compare
By default, generates a custom `Debug` implementation for all concrete structs/classes and all unions, but not abstract structs/classes. Introduces attribute `CRUBIT_OVERRIDE_DEBUG` to opt-out (or opt-in for abstract types). Unlike Rust's `derive(Debug)`, does not require all fields to `impl Debug`. However, only guaranteed to be exhaustive if all the following hold: * The type is a struct or class. * Every field is supported, named, and implements `Debug`, including non-generic Rust types that implement `Debug`. * The type has no bases. The `record_impl_debug` feature now also deprecates `CRUBIT_TRAIT_DERIVE(Debug)` in favor of the custom `Debug` implementation. PiperOrigin-RevId: 938342932
copybara-service
Bot
force-pushed
the
test_938342932
branch
from
ba3c91e to
5396103
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate
impl Debugbindings for records thatimpl_debugBy default, generates a custom
Debugimplementation for all concretestructs/classes and all unions, but not abstract structs/classes. Introduces attribute
CRUBIT_OVERRIDE_DEBUGto opt-out (or opt-in for abstract types).Unlike Rust's
derive(Debug), does not require all fields toimpl Debug.However, only guaranteed to be exhaustive if all the following hold:
Debug, including non-generic Rusttypes that implement
Debug.The
record_impl_debugfeature now also deprecatesCRUBIT_TRAIT_DERIVE(Debug)in favor of the customDebugimplementation.