Skip field nullability check at exit of &&-qualified methods#1302
Open
copybara-service[bot] wants to merge 1 commit into
Open
Skip field nullability check at exit of &&-qualified methods#1302copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
In &&-qualified methods, the object is typically consumed (e.g. in Finalize() method of a Builder), so we shouldn't warn if non-null pointer members are left null at exit. Using the moved-from object can indeed lead to errors, but diagnosing this is better left to "use-after-move" check. PiperOrigin-RevId: 940419440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip field nullability check at exit of &&-qualified methods
In &&-qualified methods, the object is typically consumed (e.g. in Finalize() method of a Builder), so we shouldn't warn if non-null pointer members are left null at exit.
Using the moved-from object can indeed lead to errors, but diagnosing this is better left to "use-after-move" check.