feat: enable concurrent replacement with key deduplication#432
Open
AmaadMartin wants to merge 2 commits into
Open
feat: enable concurrent replacement with key deduplication#432AmaadMartin wants to merge 2 commits into
AmaadMartin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Or, if no issue exists, describe the change:
Problem:
The
injectSessionStatefunction inadk-jsresolved placeholders sequentially. If the same placeholder (especially artifacts) was used multiple times, it resulted in redundant and slow service calls. It also lacked concurrency for resolving different placeholders.Solution:
Refactored
injectSessionStateto:Promise.all.resolveKeyat the module level.{artifact.name?}) by resolving to""if missing (closing parity gap with Python).Testing Plan
Unit Tests:
Summary of passed results:
loads artifact only once when duplicate placeholders are presentto verify that duplicate artifact placeholders only trigger a single load call.resolves missing optional artifact to empty string), mixed required/optional placeholders, and invalid placeholder passthrough.Checklist