feat(gooddata-sdk): [AUTO] Add ExecutionResultLimitBreak schema for partial results#1617
Open
yenkins-admin wants to merge 3 commits into
Open
feat(gooddata-sdk): [AUTO] Add ExecutionResultLimitBreak schema for partial results#1617yenkins-admin wants to merge 3 commits into
yenkins-admin wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added ExecutionResultLimitBreak SDK wrapper class and limit_breaks property on ExecutionResult to expose the new limitBreaks field in ExecutionResultMetadata. Also fixed three pre-existing type annotation gaps in filter.py and added pyarrow to allowed-unresolved-imports.
Impact: new_feature | Services:
gooddata-afm-clientSource commits (gdc-nas):
71bb41aby Mike Zelenskij — Merge pull request #22984 from gooddata/c.mze-cq-2334Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/src/gooddata_sdk/compute/model/filter.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/pyproject.tomlpackages/gooddata-sdk/tests/compute/test_execution_limit_breaks.pyAgent decisions
Decisions (5)
ExecutionResultLimitBreak placement — Added to existing execution.py alongside other compute model classes
limit_breaks access key — Access metadata as metadata.get('limitBreaks') using camelCase key
from_api None-guard for value field — raw_value = data.get('value'); value=int(raw_value) if raw_value is not None else None
Pre-existing filter.py type errors — Added explicit EmptyValueHandling | None type annotations to _empty_value_handling in RelativeDateFilter, AllTimeDateFilter, AbsoluteDateFilter
pyarrow in allowed-unresolved-imports — Added pyarrow.** to allowed-unresolved-imports in pyproject.toml
Assumptions to verify (3)
Risks (1)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_execution_limit_breaks.pyOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow