Skip to content

fix: 로딩 중 empty 조건 수정#8

Merged
goodaseul merged 1 commit into
mainfrom
dev
Mar 27, 2026
Merged

fix: 로딩 중 empty 조건 수정#8
goodaseul merged 1 commit into
mainfrom
dev

Conversation

@goodaseul

@goodaseul goodaseul commented Mar 27, 2026

Copy link
Copy Markdown
Owner

[fix]

  • 로딩 중 empty notice같이 나와서 조건을 걸어서 수정
  • 회원가입 후 nickname을 supabase metadata에 저장하도록 수정

Summary by CodeRabbit

  • Bug Fixes

    • Corrected spelling errors in Korean messages throughout the app
    • Empty state messages no longer display while loading data
  • Improvements

    • Enhanced dark mode styling for empty state displays
    • Improved user profile data handling during authentication

@vercel

vercel Bot commented Mar 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
stack-plus Ready Ready Preview, Comment Mar 28, 2026 2:07am

@goodaseul goodaseul merged commit 45ab6ef into main Mar 27, 2026
3 of 4 checks passed
@goodaseul goodaseul deleted the dev branch March 27, 2026 13:27
@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0bc6aa1-2a4b-45b4-ae4d-93ce7eb745b4

📥 Commits

Reviewing files that changed from the base of the PR and between ab45a8f and 36f6ee6.

📒 Files selected for processing (10)
  • src/api/auth.ts
  • src/api/types/auth.ts
  • src/app/(protected)/_components/add-word-button/AddWordButton.tsx
  • src/app/(protected)/dashboard/_components/RecentWords.tsx
  • src/app/(protected)/dashboard/_components/memo/MemoBanner.tsx
  • src/app/(protected)/dashboard/_components/record/RecordChart.tsx
  • src/app/(protected)/record/_components/Record.tsx
  • src/app/(public)/join/page.tsx
  • src/components/empty-state/EmptyState.tsx
  • src/providers/AuthProvider.tsx

📝 Walkthrough

Walkthrough

This pull request updates authentication type names from response-based naming to parameter-based naming, integrates Supabase auth metadata for nickname handling, corrects Korean language text throughout the UI, and improves loading state handling and dark mode support in components.

Changes

Cohort / File(s) Summary
Authentication Type System
src/api/types/auth.ts, src/api/auth.ts
Renamed SignUpResponse/SignInResponse types to SignUpParams/SignInParams. Updated signUp and signIn function signatures to use renamed types. Added Supabase auth options payload setting nickname from user metadata during signup.
Korean Text Corrections
src/app/(protected)/_components/add-word-button/AddWordButton.tsx, src/app/(protected)/dashboard/_components/RecentWords.tsx, src/app/(protected)/dashboard/_components/memo/MemoBanner.tsx, src/app/(protected)/dashboard/_components/record/RecordChart.tsx, src/app/(protected)/record/_components/Record.tsx
Corrected Korean text from "표현가" to "표현이" across multiple notification and empty-state messages. Fixed capitalization consistency.
Loading State & UI Enhancements
src/app/(protected)/record/_components/Record.tsx, src/components/empty-state/EmptyState.tsx
Added loading state check to prevent empty state display during data fetching. Enhanced dark mode styling by adding dark:text-white class to empty state text.
Auth Provider & Join Flow
src/providers/AuthProvider.tsx, src/app/(public)/join/page.tsx
Modified AuthProvider to derive nickname from session.user.user_metadata?.nickname first, with fallback to profile fetch. Fixed parameter typo (sesseionsession). Reordered nickname field in signup payload construction.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A typo here, a type rename there,
Korean words we fixed with care,
Metadata flows through sessions bright,
Dark mode shines, loading feels right,
All in service of auth's light! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant