packages: wolfi import batch 4 — node (eslint, lerna, json-server, serve)#370
Open
bryan-minimal wants to merge 1 commit into
Open
packages: wolfi import batch 4 — node (eslint, lerna, json-server, serve)#370bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
Fourth batch from `pkgmgr import-wolfi` — node CLI tools. Node installs from
the npm registry by name+version (cf. typescript-language-server), so these
have no Source: build.sh runs `npm install -g --prefix=$OUTPUT_DIR/usr
<name>@$MINIMAL_ARG_VERSION`, with base+node build_deps, coreutils+node runtime,
a needs{dns,internet} block, and outputs = console-script bins + node_modules.
Each builds clean and passes every `minimal check` at 0 TODOs.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR adds build specifications and install scripts for four new npm-based packages: eslint (10.6.0), json-server (0.17.4), lerna (9.0.7), and serve (14.2.6). Each package includes a build.ncl spec and a build.sh script performing global npm installs. ChangesNew npm package build specs
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth batch from
pkgmgr import-wolfi— node CLI tools. Node is a different shape from the tarball-built families: Minimal installs node CLIs from the npm registry by name+version (cf. typescript-language-server), not from a github source — so these have noSource, theynpm install -gat build time.What's here (4 packages, all build + pass every
minimal checkat 0 TODOs)@nxaddons)How they're produced
npm install -g --prefix="$OUTPUT_DIR/usr" <name>@$MINIMAL_ARG_VERSION.base+nodebuild_deps,coreutils+noderuntime_deps, aneeds = { dns, internet }block for the npm fetch, andbuild_args { include version }.usr/bin/<tool>is a symlink intonode_modules) +node_modules(allow_executable— some packages ship native.nodeaddons). Read from a verified build.Reviewer notes (surfaced, not hidden)
source_provenance— node packages install from the npm registry, not a pinned github tarball, so there's no'GithubRepoprovenance for vuln-scanning (matches Minimal's existing node packages like typescript-language-server). Worth a follow-up: an npm PURL for scan coverage.typescript). These 4 resolve their own deps vianpm install; the generated build.sh installs the single named package, and the import surfaces a reviewer note to add peers if a tool needs them.🤖 Generated with Claude Code
Summary by CodeRabbit
eslint,json-server,lerna, andserve.