Fix unsubscribe#29
Open
nothize wants to merge 2 commits into
Open
Conversation
This reveals a bug that when there is more than 1 subscribers, the end result will always contain the observer to be removed. In general, where n is the length of the subscriber list when n = 1, works as expected when n > 1, subscriber list = [observer to be removed] x (n-1)
Use a more efficient way to construct the new subscribe list while fixing the bug.
Contributor
Author
|
@creack @indrekj @joelreymont @uwe Please review, thanks! |
Member
|
I'll give it a shot over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unsubscribe all and unmatched bug that removed other observers
Use a more efficient way to construct the new subscribe list while
fixing the bug.
A test case is included as an earlier commit so that the bug can be reproduced by running the test case: