Skip to content

small changes here and there - #105

Open
bgruening wants to merge 1 commit into
goeckslab:mainfrom
bgruening:stack
Open

small changes here and there#105
bgruening wants to merge 1 commit into
goeckslab:mainfrom
bgruening:stack

Conversation

@bgruening

Copy link
Copy Markdown
Collaborator

Some small changes, mostly for linting I found during review.

Enjoy GCC!


This PR is related to

  • Adding a new tool
  • Updating an existing tool to a newer version
  • Fixing a bug or updating just the Galaxy wrapper of an existing tool
  • Making a change to the tools-mti repo, CI, or other misc. change

If updating an existing tool to a newer major version

  • I have updated the TOOL_VERSION token in the tool's macros file
  • I have reset the VERSION_SUFFIX to 0 in the tool's macros file

Provide details here

  • Cite relevant issues if applicable
  • If fixing a bug, please add any relevant error or traceback
  • If adding or updating tools, please describe how tool requirements are satisfied (Examples: "Created new Docker container for scimap", "Added scimap to Bioconda", etc.)

@luke-c-sargent

Copy link
Copy Markdown
Member

Thanks for the changes @bgruening! A couple questions related to versioning:

  • in general, should structural changes (e.g., removing a space or a newline) cause a VERSION_SUFFIX bump?
  • what about .shed.yml changes like with backsub here?

my intuition is that backsub, squidpy_spatial, and scimap_spatial should have VERSION_SUFFIX increments in addition to mesmer's increment, but i wanted to make sure it that was the right call ;)

@bgruening

Copy link
Copy Markdown
Collaborator Author

in general, should structural changes (e.g., removing a space or a newline) cause a VERSION_SUFFIX bump?

This is not striclty needed, but on IUC we have decided to make it easy for review and CI and request always a bump. Your gut feeling is correct - technically :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants