fix: remove hardcoded propagation_lag, make detector params configurable - #259
Open
godon-robot[bot] wants to merge 1 commit into
Open
fix: remove hardcoded propagation_lag, make detector params configurable#259godon-robot[bot] wants to merge 1 commit into
godon-robot[bot] wants to merge 1 commit into
Conversation
…gurable propagation_lag was hardcoded at 20.0 seconds (greenhouse thermal lag). For the generic bench, coupling is instant — 20s lag causes the push and pause windows to overlap, contaminating the baseline and inflating the CFAR threshold. All detector params now read from env vars with sane defaults: - GODON_PROPAGATION_LAG (default 0.0 — instant) - GODON_MIN_REF_CELLS (default 3) - GODON_MIN_TEST_CELLS (default 3) Systems with slow coupling (greenhouses, HVAC) set GODON_PROPAGATION_LAG explicitly. Default 0 covers the majority of use cases. Co-authored-by: cherusk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
propagation_lag was 20s hardcoded. Made configurable via env. Default 0.
Co-authored-by: cherusk [email protected]