chore(ci): add actionlint to the Lint job#308
Merged
Conversation
actionlint catches GitHub Actions YAML mistakes that golangci-lint can't: script-injection vectors, unknown runner labels, malformed shell, action input misuse. Runs on every PR / push as the final step on the existing Lint job — same checkout + setup-go infrastructure, ~5s overhead.
- ci.yml: quote the go-list \$pkgs expansion (SC2046). Word-splitting is intentional here — \`go test\` wants one package per arg — so split it onto its own line + suppress the lint with a targeted directive. - drivers.yml: rename the unused \`i\` loop var to \`_\` (SC2034). Caught immediately by adding actionlint+shellcheck to the Lint job — exactly the kind of finding the integration is meant to surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds actionlint to the existing Lint job so this repo's own GitHub Actions YAML is sanity-checked on every PR — script-injection vectors, unknown runner labels, malformed shell, action input misuse. ~5s overhead, uses the same checkout + setup-go that already runs.