Addressing subtask indentation feature request#294
Conversation
Subtask entries returned by the API as separate items are now properly filtered from list/kanban/project views and nested under their parent tasks. Uses flattenAndRemoveSubtasks to merge subtask data into parents and remove top-level duplication across both TaskPageController and ProjectController. Co-authored-by: CommandCodeBot <[email protected]>
Subtask entries returned by the API as separate items are now properly filtered from list/kanban/project views and nested under their parent tasks. Uses flattenAndRemoveSubtasks to merge subtask data into parents and remove top-level duplication across both TaskPageController and ProjectController. Co-authored-by: CommandCodeBot <[email protected]>
|
Hi @leschbenedikt, could you help push the review the code and push it for CI when available? |
leschbenedikt
left a comment
leschbenedikt
left a comment
There was a problem hiding this comment.
Thanks for you work.
Unfortunately this does not work correctly at the moment.
I've created a task with a sub task which has a sub task itself like this.
Parent Task -> Sub Task -> Sub sub Task
On the web page this will be displayed like this in overview and upcoming:
In the project page, it will be displayed like this:
In the home page of the android app the sub sub taks is missing.
Also they are indented which differs from the web page:
In the project page the indentation would be correct but also sub sub task is missing:
| createdBy: b.createdBy != null ? UserDto.fromDomain(b.createdBy!) : null, | ||
| ); | ||
|
|
||
| static int? _extractParentTaskId(Map<String, dynamic> json) { |
There was a problem hiding this comment.
If I understand that correctly 'related_tasks' is the new api and it was 'parent_task' before.
We don't want to support outdated api from the pre 1.0 release in the app. So please use only the newest one.
For future changes we will have api versioning.
2 participants
The subtask request #57 should be fixed with this change, tested on an android emulator, g_pixel_34.
Subtasks seem to generate fine.
Please do let me know if any changes are required.