Skip to content

fix: Detect interfaces without external connectivity probe #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulb-firebolt wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix: Detect interfaces without external connectivity probe #1577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 12 additions & 38 deletions server/util/loadInterfaces.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import os from 'node:os';
import https from 'node:https';
import * as config from '../controller/config.js';

export let interfaces = {};
Expand All @@ -15,40 +14,14 @@ export const requestInterfaces = async () => {

if (address.internal) continue;

let options = {hostname: "speed.cloudflare.com", path: "/__down?bytes=1", method: "GET",
family: address.family === "IPv4" ? 4 : 6, timeout: 5000};

options.agent = new https.Agent(options);
options.localAddress = address.address;

await new Promise((resolve) => {

const req = https.request(options, () => {
if (!interfacesResult[i]) interfacesResult[i] = [];
interfacesResult[i].push(address.address);
req.destroy();
resolve();
});

req.on('error', () => resolve());
req.on('timeout', () => req.destroy());

req.end();
});
if (!interfacesResult[i]) interfacesResult[i] = [];
interfacesResult[i].push(address.address);
}

if (!interfacesResult[i]) delete interfacesResult[i];
}

interfaces = {};
for (let i in interfacesResult) {
for (let j in interfacesResult[i]) {
if (interfacesResult[i][j].includes(".")) {
interfaces[i] = interfacesResult[i][j];
break;
}
}

if (!interfaces[i]) interfaces[i] = interfacesResult[i][0];
interfaces[i] = interfacesResult[i].find((address) => address.includes(".")) || interfacesResult[i][0];
}

for (let i in interfaces) {
Expand All @@ -57,12 +30,13 @@ export const requestInterfaces = async () => {

const currentInterface = await config.getValue("interface");

if (!interfaces[currentInterface]) {
if (!currentInterface) {
console.warn("No interface set. Falling back to default.");
} else {
console.warn(`Interface ${currentInterface} not found. Falling back to default.`);
}
await config.updateValue("interface", Object.keys(interfaces)[0]);
if (currentInterface && interfaces[currentInterface]) return;

if (!currentInterface) {
console.warn("No interface set. Falling back to default.");
} else {
console.warn(`Interface ${currentInterface} not found. Falling back to default.`);
}

await config.updateValue("interface", Object.keys(interfaces)[0] || "none");
};